linux-kernel - Re: [PATCH] tracing: Add saved_tgids file to show cached pid to tgid mappings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 2 Jul 2017 09:47:20 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Michael Sartain <mikesart@...tmail.com>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Joel Fernandes <joelaf@...gle.com>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>
Subject: Re: [PATCH] tracing: Add saved_tgids file to show cached pid to tgid
 mappings

Hi Michael,

[auto build test ERROR on trace/for-next]
[also build test ERROR on next-20170630]
[cannot apply to tip/perf/core linus/master v4.12-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Michael-Sartain/tracing-Add-saved_tgids-file-to-show-cached-pid-to-tgid-mappings/20170702-092448
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next
config: i386-randconfig-x070-07010433 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   kernel//trace/trace.c: In function 'saved_cmdlines_next':
>> kernel//trace/trace.c:4612:22: error: implicit declaration of function 'trace_find_tgid' [-Werror=implicit-function-declaration]
      if (tgid_check && !trace_find_tgid(*ptr))
                         ^~~~~~~~~~~~~~~
   kernel//trace/trace.c: In function 'saved_cmdlines_start':
>> kernel//trace/trace.c:4627:21: error: 'tgid_map' undeclared (first use in this function)
     if (tgid_check && !tgid_map)
                        ^~~~~~~~
   kernel//trace/trace.c:4627:21: note: each undeclared identifier is reported only once for each function it appears in
   cc1: some warnings being treated as errors

vim +/trace_find_tgid +4612 kernel//trace/trace.c

  4606		(*pos)++;
  4607	
  4608		for (; ptr < &savedcmd->map_cmdline_to_pid[savedcmd->cmdline_num];
  4609		     ptr++) {
  4610			if (*ptr == -1 || *ptr == NO_CMDLINE_MAP)
  4611				continue;
> 4612			if (tgid_check && !trace_find_tgid(*ptr))
  4613				continue;
  4614	
  4615			return ptr;
  4616		}
  4617	
  4618		return NULL;
  4619	}
  4620	
  4621	static void *saved_cmdlines_start(struct seq_file *m, loff_t *pos)
  4622	{
  4623		void *v;
  4624		loff_t l = 0;
  4625		long tgid_check = (long) m->private;
  4626	
> 4627		if (tgid_check && !tgid_map)
  4628			return NULL;
  4629	
  4630		preempt_disable();

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (26667 bytes)