linux-kernel - Re: [PATCH v2] staging: sm750fb: refactor method and fix potential type inconsistence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Jul 2017 08:20:40 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lynn Lei <lynnl.wit@...il.com>
Cc:     sudipm.mukherjee@...il.com, devel@...verdev.osuosl.org,
        linux-fbdev@...r.kernel.org, teddy.wang@...iconmotion.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: sm750fb: refactor method and fix potential
 type inconsistence

On Sun, Jul 02, 2017 at 10:40:33PM +0800, Lynn Lei wrote:
> include PANEL_DISPLAY_CTRL_FPVDDEN control mask


Does the subject match this?

> Signed-off-by: Lynn Lei <lynnl.wit@...il.com>
> ---
>  drivers/staging/sm750fb/ddk750_display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/sm750fb/ddk750_display.c b/drivers/staging/sm750fb/ddk750_display.c
> index 0f666dc2729a..c68367e6cdeb 100644
> --- a/drivers/staging/sm750fb/ddk750_display.c
> +++ b/drivers/staging/sm750fb/ddk750_display.c
> @@ -89,7 +89,7 @@ static void swPanelPowerSequence(int disp, int delay)
>  	u32 reg;
>  	u32 opt[] = {
>  		PANEL_DISPLAY_CTRL_FPEN, PANEL_DISPLAY_CTRL_DATA,
> -		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPEN,
> +		PANEL_DISPLAY_CTRL_VBIASEN, PANEL_DISPLAY_CTRL_FPVDDEN,

Are you sure this is allowed?  Why is this patch correct?

And again, it doesn't match the subject line :(

greg k-h