linux-kernel - Re: [PATCH] staging: sm750fb: refactor method and fix potential type inconsistence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 3 Jul 2017 08:22:29 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Lynn Lei <lynnl.wit@...il.com>
Cc:     sudipm.mukherjee@...il.com, teddy.wang@...iconmotion.com,
        linux-fbdev@...r.kernel.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: sm750fb: refactor method and fix potential type
 inconsistence

On Sun, Jul 02, 2017 at 10:27:40PM +0800, Lynn Lei wrote:
> make reg variable typed `u32' not `unsigned int'
> this can fix potential type inconsistence in some platforms

It can?  What platform?

> 
> refactor swPanelPowerSequence() make the code less redundant
> 
> a early check for disp to skip unnecessary delay

Only do one thing per patch please.

thanks,

greg k-h