lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 4 Jul 2017 12:08:09 +0800 From: Hanjun Guo <guohanjun@...wei.com> To: Corey Minyard <minyard@....org> CC: G Gregory <graeme.gregory@...aro.org>, <linux-kernel@...r.kernel.org>, Hanjun Guo <hanjun.guo@...aro.org> Subject: [PATCH] char: ipmi: eliminate misleading print info when being probed via ACPI From: Hanjun Guo <hanjun.guo@...aro.org> When ipmi is probed via ACPI, the boot log shows [ 17.945139] ipmi_si IPI0001:00: probing via device tree [ 17.950369] ipmi_si IPI0001:00: ipmi_si: probing via ACPI [ 17.955795] ipmi_si IPI0001:00: [io 0x00e4-0x3fff] regsize 1 spacing 1 irq 0 [ 17.962932] ipmi_si: Adding ACPI-specified bt state machine which "ipmi_si IPI0001:00: probing via device tree" is misleading with a ACPI HID "IPI0001" but probing via DT. Eliminate this misleading print info by checking of_node is valid or not before calling of_ipmi_probe(). Signed-off-by: Hanjun Guo <hanjun.guo@...aro.org> --- drivers/char/ipmi/ipmi_si_intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/ipmi/ipmi_si_intf.c b/drivers/char/ipmi/ipmi_si_intf.c index 59ee93e..159950d 100644 --- a/drivers/char/ipmi/ipmi_si_intf.c +++ b/drivers/char/ipmi/ipmi_si_intf.c @@ -2810,7 +2810,7 @@ static int acpi_ipmi_probe(struct platform_device *dev) static int ipmi_probe(struct platform_device *dev) { - if (of_ipmi_probe(dev) == 0) + if (dev->dev.of_node && of_ipmi_probe(dev) == 0) return 0; return acpi_ipmi_probe(dev); -- 1.7.12.4
Powered by blists - more mailing lists