linux-kernel - Re: [PATCH] KVM: vmx: expose more information for KVM_INTERNAL_ERROR_DELIVERY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 5 Jul 2017 14:26:15 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     David Hildenbrand <david@...hat.com>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH] KVM: vmx: expose more information for
 KVM_INTERNAL_ERROR_DELIVERY_EV exits



On 05/07/2017 14:25, David Hildenbrand wrote:
>>  		vcpu->run->internal.suberror = KVM_INTERNAL_ERROR_DELIVERY_EV;
>> -		vcpu->run->internal.ndata = 2;
>> +		vcpu->run->internal.ndata = 3;
>>  		vcpu->run->internal.data[0] = vectoring_info;
>>  		vcpu->run->internal.data[1] = exit_reason;
>> +		vcpu->run->internal.data[2] = vcpu->arch.exit_qualification;
>> +		if (exit_reason == EXIT_REASON_EPT_MISCONFIG) {
>> +			vcpu->run->internal.ndata++;
>> +			vcpu->run->internal.data[3] =
>> +				vmcs_read64(GUEST_PHYSICAL_ADDRESS);
> vcpu->run->internal.data[vcpu->run->internal.ndata++] = ...

I considered that, but it's very long and the initializations above use
numbers.  Considering that this is not going to change very often, I
ended up with the hard coded 3.

Paolo

> So we don't have to name the position explicitly.
> 
> Whatever you prefer.
> 
> Reviewed-by: David Hildenbrand <david@...hat.com>
>