linux-kernel - [PATCH] nfc: nxp-nci: constify acpi_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Thu,  6 Jul 2017 22:20:00 +0530
From:   Arvind Yadav <arvind.yadav.cs@...il.com>
To:     clement.perrochaud@...innov.com, charles.gorand@...innov.com,
        sameo@...ux.intel.com
Cc:     linux-nfc@...ts.01.org, linux-wireless@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: [PATCH] nfc: nxp-nci: constify acpi_device_id.

acpi_device_id are not supposed to change at runtime. All functions
working with acpi_device_id provided by <acpi/acpi_bus.h> work with
const acpi_device_id. So mark the non-const structs as const.

File size before:
   text	   data	    bss	    dec	    hex	filename
   2208	    400	      0	   2608	    a30	drivers/nfc/nxp-nci/i2c.o

File size After adding 'const':
   text	   data	    bss	    dec	    hex	filename
   2272	    336	      0	   2608	    a30	drivers/nfc/nxp-nci/i2c.o

Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>
---
 drivers/nfc/nxp-nci/i2c.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nfc/nxp-nci/i2c.c b/drivers/nfc/nxp-nci/i2c.c
index ff22d76..35d4fc5 100644
--- a/drivers/nfc/nxp-nci/i2c.c
+++ b/drivers/nfc/nxp-nci/i2c.c
@@ -407,7 +407,7 @@ static const struct of_device_id of_nxp_nci_i2c_match[] = {
 MODULE_DEVICE_TABLE(of, of_nxp_nci_i2c_match);
 
 #ifdef CONFIG_ACPI
-static struct acpi_device_id acpi_id[] = {
+static const struct acpi_device_id acpi_id[] = {
 	{ "NXP7471" },
 	{ },
 };
-- 
2.7.4