lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Fri, 7 Jul 2017 09:43:39 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Stafford Horne <shorne@...il.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kselftest@...r.kernel.org, shuah@...nel.org,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
        naresh.kamboju@...aro.org
Subject: Re: [PATCH 4/4] selftests: ftrace: Output only to console with
 "--logdir -"

On Thu, 6 Jul 2017 22:06:58 +0900
Stafford Horne <shorne@...il.com> wrote:

> On Wed, Jul 05, 2017 at 12:25:06PM -0400, Steven Rostedt wrote:
> > On Tue,  4 Jul 2017 15:38:55 +0900
> > Masami Hiramatsu <mhiramat@...nel.org> wrote:
> > 
> > > +    local testlog=`mktemp $LOG_DIR/${testname}-log.XXXXXX`
> > > +  else
> > > +    local testlog=`/proc/self/fd/1`
> > 
> > cute trick.
> 
> Shouldn't this be:
> 
>    local testlog=/proc/self/fd/1
> 
> without the backticks and subshell? We just want to write to the stdout
> file not execute it.

Yeah, it was my mistake...

Thank you!

> 
> Or am missing something.
> 
> -Stafford


-- 
Masami Hiramatsu <mhiramat@...nel.org>

Powered by blists - more mailing lists