linux-kernel - Re: irq: Invalid fwnode type (2) for irqdomain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 08 Jul 2017 10:45:25 +0100
From:   Marc Zyngier <marc.zyngier@....com>
To:     Paul Menzel <pmenzel@...gen.mpg.de>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        John Garry <john.garry@...wei.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: irq: Invalid fwnode type (2) for irqdomain

On Sat, Jul 08 2017 at  9:28:17 am BST, Paul Menzel <pmenzel@...gen.mpg.de> wrote:

Hi Paul,


>> I've been reported an issue that is somewhat related to this, Any
>> chance you could give this[1] a go? I have no way to test it...
>
> The commit below indeed made the warning go away.
>
>> commit 6bf31c05f2a967e5351a3050ef51c18c8c9ee291
>> Author: Marc Zyngier <marc.zyngier@....com>
>> Date:   Thu Jul 6 14:51:31 2017 +0100
>> 
>>     irqdomain: Allow ACPI device nodes to be used as irqdomain identifiers
>>     
>>     A number of irqchip implementations are (ab)using the irqdomain
>>     allocator by passing a fwnode that is neither a FWNODE_OF or
>>     a FWNODE_IRQCHIP.
>>     
>>     This is pretty bad, but it also feels pretty crap to force these
>>     drivers to allocate their own irqchip_fwid when they already have
>>     a proper fwnode.
>>     
>>     Instead, let's teach the irqdomain allocator about ACPI device
>>     nodes, and add some lovely name generation code... Tested on
>>     an arm64 D05 system.
>>     
>>     Reported-by: John Garry <john.garry@...wei.com>
>>     Signed-off-by: Marc Zyngier <marc.zyngier@....com>
>
> I wonder if a warning/debug messages could and should still be shown,
> if a fwnode is neither a FWNODE_OF or a FWNODE_IRQCHIP.

With this patch, the code covers FWNODE_OF, FWNODE_IRQCHIP and
FWNODE_ACPI (the latter being the case you and John uncovered). Should
we get any other fwnode_type value, the irqdomain code will still warn
the user that this is not an object type we're ready to accept.

Thanks again for the report and the testing.

	M.
-- 
Jazz is not dead. It just smells funny.