linux-kernel - Re: [PATCH V2 5/5] spmi: pmic-arb: use irq_chip callback to set spmi irq wakeup capability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 10 Jul 2017 18:22:36 -0700
From:   Stephen Boyd <sboyd@...eaurora.org>
To:     Kiran Gunda <kgunda@...eaurora.org>
Cc:     gregkh@...uxfoundation.org,
        Abhijeet Dharmapurikar <adharmap@...eaurora.org>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Nicholas Troast <ntroast@...eaurora.org>,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH V2 5/5] spmi: pmic-arb: use irq_chip callback to set spmi
 irq wakeup capability

On 07/10, Kiran Gunda wrote:
> Currently the driver sets the pmic arbiter core interrupt as wakeup capable
> irrespective of the child irqs which causes the system to wakeup
> unnecessarily. To fix this, set the core interrupt as wakeup capable
> only if any of the child irqs request for it. Do this by marking it as
> wakeup capable in the irq_set_wake callback.
> 
> Signed-off-by: Kiran Gunda <kgunda@...eaurora.org>
> ---

Reviewed-by: Stephen Boyd <sboyd@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project