linux-kernel - Re: [linux-next][PATCH] usb: dwc3: core: Call dwc3_core_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Jul 2017 17:30:53 -0500
From:   Vignesh R <vigneshr@...com>
To:     Felipe Balbi <balbi@...nel.org>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <linux-usb@...r.kernel.org>, <linux-omap@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Tony Lindgren <tony@...mide.com>,
        Carlos Hernandez <ceh@...com>
Subject: Re: [linux-next][PATCH] usb: dwc3: core: Call dwc3_core_get_phy()
 before initializing phys



On 6/29/2017 12:25 AM, Vignesh R wrote:
> commit f54edb539c116 ("usb: dwc3: core: initialize ULPI before trying to
> get the PHY") moved call to dwc3_core_get_phy() from dwc3_probe() to
> dwc3_core_init() after dwc3_core_soft_reset(). But
> dwc3_core_soft_reset() calls phy_init(), therefore dwc3_core_get_phy()
> needs to be called before dwc3_core_soft_reset().
> 
> Fix this by moving call to dwc3_core_get_phy() before
> dwc3_core_soft_reset().
> 
> This fixes the following abort seen on DRA7xx platforms
> [   24.769118] usb usb2: SerialNumber: xhci-hcd.1.auto
> [   24.781144] hub 2-0:1.0: USB hub found
> [   24.787836] hub 2-0:1.0: 1 port detected
> [   24.809939] Unhandled fault: imprecise external abort (0x1406) at 0x00000000
> 
> Reported-by: Carlos Hernandez <ceh@...com>
> Signed-off-by: Vignesh R <vigneshr@...com>
> ---

Could this be picked up for -rc1, so that we have a booting kernel for
dra7 platform? Or is this planned for -rc2?

>  drivers/usb/dwc3/core.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c
> index 326b302fc440..03474d3575ab 100644
> --- a/drivers/usb/dwc3/core.c
> +++ b/drivers/usb/dwc3/core.c
> @@ -766,15 +766,15 @@ static int dwc3_core_init(struct dwc3 *dwc)
>  			dwc->maximum_speed = USB_SPEED_HIGH;
>  	}
>  
> -	ret = dwc3_core_soft_reset(dwc);
> +	ret = dwc3_core_get_phy(dwc);
>  	if (ret)
>  		goto err0;
>  
> -	ret = dwc3_phy_setup(dwc);
> +	ret = dwc3_core_soft_reset(dwc);
>  	if (ret)
>  		goto err0;
>  
> -	ret = dwc3_core_get_phy(dwc);
> +	ret = dwc3_phy_setup(dwc);
>  	if (ret)
>  		goto err0;
>  
>