linux-kernel - Re: [PATCH 3/3] fat: fix quoted string splits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 15 Jul 2017 04:20:01 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Carlos Palminha <CARLOS.PALMINHA@...opsys.com>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>,
        Alexander Viro <viro@...iv.linux.org.uk>
Subject: Re: [PATCH 3/3] fat: fix quoted string splits

On Sat, Jul 15, 2017 at 2:05 AM, Carlos Palminha
<CARLOS.PALMINHA@...opsys.com> wrote:
> corrects quoted string split across lines, based on checkpatch.

At some point you may switch

fat_msg(sb, KERN_ERR, ...)

to

fat_fs_error(sb, ...)

>
> Signed-off-by: Carlos Palminha <palminha@...opsys.com>
> ---
>  fs/fat/cache.c |  4 ++--
>  fs/fat/inode.c | 18 ++++++++++--------
>  2 files changed, 12 insertions(+), 10 deletions(-)
>
> diff --git a/fs/fat/cache.c b/fs/fat/cache.c
> index 470b4831079e..1fa1fd72bcfb 100644
> --- a/fs/fat/cache.c
> +++ b/fs/fat/cache.c
> @@ -250,8 +250,8 @@ int fat_get_cluster(struct inode *inode, int cluster, int *fclus, int *dclus)
>                 /* prevent the infinite loop of cluster chain */
>                 if (*fclus > limit) {
>                         fat_fs_error_ratelimit(sb,
> -                                       "%s: detected the cluster chain loop"
> -                                       " (i_pos %lld)", __func__,
> +                                       "%s: detected the cluster chain loop (i_pos %lld)",
> +                                       __func__,
>                                         MSDOS_I(inode)->i_pos);
>                         nr = -EIO;
>                         goto out;
> diff --git a/fs/fat/inode.c b/fs/fat/inode.c
> index 8d65174b7d75..23ffac04ec7b 100644
> --- a/fs/fat/inode.c
> +++ b/fs/fat/inode.c
> @@ -1673,8 +1673,8 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
>                 /* Verify that the larger boot sector is fully readable */
>                 bh_resize = sb_bread(sb, 0);
>                 if (bh_resize == NULL) {
> -                       fat_msg(sb, KERN_ERR, "unable to read boot sector"
> -                              " (logical sector size = %lu)",
> +                       fat_msg(sb, KERN_ERR,
> +                               "unable to read boot sector (logical sector size = %lu)",
>                                sb->s_blocksize);
>                         goto out_fail;
>                 }
> @@ -1710,15 +1710,16 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
>
>                 fsinfo_bh = sb_bread(sb, sbi->fsinfo_sector);
>                 if (fsinfo_bh == NULL) {
> -                       fat_msg(sb, KERN_ERR, "bread failed, FSINFO block"
> -                              " (sector = %lu)", sbi->fsinfo_sector);
> +                       fat_msg(sb, KERN_ERR,
> +                               "bread failed, FSINFO block (sector = %lu)",
> +                               sbi->fsinfo_sector);
>                         goto out_fail;
>                 }
>
>                 fsinfo = (struct fat_boot_fsinfo *)fsinfo_bh->b_data;
>                 if (!IS_FSINFO(fsinfo)) {
> -                       fat_msg(sb, KERN_WARNING, "Invalid FSINFO signature: "
> -                              "0x%08x, 0x%08x (sector = %lu)",
> +                       fat_msg(sb, KERN_WARNING,
> +                               "Invalid FSINFO signature: 0x%08x, 0x%08x (sector = %lu)",
>                                le32_to_cpu(fsinfo->signature1),
>                                le32_to_cpu(fsinfo->signature2),
>                                sbi->fsinfo_sector);
> @@ -1745,8 +1746,9 @@ int fat_fill_super(struct super_block *sb, void *data, int silent, int isvfat,
>         sbi->dir_entries = bpb.fat_dir_entries;
>         if (sbi->dir_entries & (sbi->dir_per_block - 1)) {
>                 if (!silent)
> -                       fat_msg(sb, KERN_ERR, "bogus number of directory entries"
> -                              " (%u)", sbi->dir_entries);
> +                       fat_msg(sb, KERN_ERR,
> +                               "bogus number of directory entries (%u)",
> +                               sbi->dir_entries);
>                 goto out_invalid;
>         }
>
> --
> 2.11.0
>



-- 
With Best Regards,
Andy Shevchenko