linux-kernel - Re: [PATCH] mfd: rtsx: make arrays depth and cd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 11:46:44 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: rtsx: make arrays depth and cd_mask static const

Please start the commit subject description with an uppercase char.

> From: Colin Ian King <colin.king@...onical.com>

This is odd.  How are you sending this patch Colin?

> Don't populate the arrays depath and cd_mask on the stack but make
> them static const.  Makes the object code smaller:
> 
>    text    data     bss     dec     hex filename
>   25413    7216     448   33077    8135 drivers/mfd/rtsx_pcr.o
> 
>    text    data     bss     dec     hex filename
>   25151    7360     448   32959    80bf drivers/mfd/rtsx_pcr.o
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/mfd/rtsx_pcr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

I'll fix the $SUBJECT line.

Applied, thanks.

> diff --git a/drivers/mfd/rtsx_pcr.c b/drivers/mfd/rtsx_pcr.c
> index a0ac89dfdf0f..3cf69e5c5703 100644
> --- a/drivers/mfd/rtsx_pcr.c
> +++ b/drivers/mfd/rtsx_pcr.c
> @@ -644,7 +644,7 @@ int rtsx_pci_switch_clock(struct rtsx_pcr *pcr, unsigned int card_clock,
>  {
>  	int err, clk;
>  	u8 n, clk_divider, mcu_cnt, div;
> -	u8 depth[] = {
> +	static const u8 depth[] = {
>  		[RTSX_SSC_DEPTH_4M] = SSC_DEPTH_4M,
>  		[RTSX_SSC_DEPTH_2M] = SSC_DEPTH_2M,
>  		[RTSX_SSC_DEPTH_1M] = SSC_DEPTH_1M,
> @@ -768,7 +768,7 @@ EXPORT_SYMBOL_GPL(rtsx_pci_card_power_off);
>  
>  int rtsx_pci_card_exclusive_check(struct rtsx_pcr *pcr, int card)
>  {
> -	unsigned int cd_mask[] = {
> +	static const unsigned int cd_mask[] = {
>  		[RTSX_SD_CARD] = SD_EXIST,
>  		[RTSX_MS_CARD] = MS_EXIST
>  	};

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog