linux-kernel - Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a bool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 12:04:15 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Hans de Goede <hdegoede@...hat.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: intel_soc_pmic_chtwc: Turn Kconfig option into a
 bool

On Fri, 23 Jun 2017, Hans de Goede wrote:

> The PMIC provides ACPI OpRegions which must be available for other
> drivers' PS0 / PS3 methods early-on as such it must be builtin as the
> Kconfig help text already states.
> 
> Somehow its Kconfig option ended up being a tristate though, this fixes
> this.
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---
> Note, feel free to squash this in the original commit if you wish

Looks like the original commit is yet to be accepted.

Please ensure it's squashed in and resubmit.

> ---
>  drivers/mfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 8533cb46a875..be962d128f31 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -476,7 +476,7 @@ config INTEL_SOC_PMIC_BXTWC
>  	  on these systems.
>  
>  config INTEL_SOC_PMIC_CHTWC
> -	tristate "Support for Intel Cherry Trail Whiskey Cove PMIC"
> +	bool "Support for Intel Cherry Trail Whiskey Cove PMIC"
>  	depends on ACPI && HAS_IOMEM && I2C=y && COMMON_CLK
>  	depends on X86 || COMPILE_TEST
>  	select MFD_CORE

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog