linux-kernel - Re: [PATCH v2 1/4] w1: ds1wm: fix and simplify register access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 16:55:50 +0200
From:   Greg Kroah-Hartman <greg@...ah.com>
To:     Johannes Poehlmann <johannes.poehlmann@...-labs.de>
Cc:     linux-kernel@...r.kernel.org, Evgeniy Polyakov <zbr@...emap.net>
Subject: Re: [PATCH v2 1/4] w1: ds1wm: fix and simplify register access

On Fri, Jun 23, 2017 at 12:47:12PM +0200, Johannes Poehlmann wrote:
> o Replace incorrect register offsett calculation by
> direct configuration of bus_shift in mfd-cell.
> Indirect definition of address-shift by resource size
> was unobvious and should have used a binary log.
> o Make endian clean, make HW-endianness configurable.
> o Use ioread*, iowrite* instead of __raw_readb,__raw_writeb
> to also use memory-barriers when accessing HW-registers.
> We do not want reordering to happen here.
> 
> Signed-off-by: Johannes Poehlmann <johannes.poehlmann@...-labs.de>
> Acked-by: Evgeniy Polyakov <zbr@...emap.net>
> 
> 78	6	drivers/w1/masters/ds1wm.c
> 9	0	include/linux/mfd/ds1wm.h

And again, something went wrong here :(