linux-kernel - Re: [PATCH] dt-bindings: regulator: pwm-regulator: fix example syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 17 Jul 2017 15:18:47 -0500
From:   Rob Herring <robh@...nel.org>
To:     Martin Blumenstingl <martin.blumenstingl@...glemail.com>
Cc:     devicetree@...r.kernel.org, lgirdwood@...il.com,
        broonie@...nel.org, linux-kernel@...r.kernel.org,
        mark.rutland@....com
Subject: Re: [PATCH] dt-bindings: regulator: pwm-regulator: fix example syntax

On Mon, Jul 17, 2017 at 03:18:23PM +0200, Martin Blumenstingl wrote:
> The "Continuous Voltage" example specifies a pwm-dutycycle-range.
> However, an equal sign is missing between the property name and value.
> Fix this to allow copy and paste from the documentation when writing an
> own .dts file with a pwm-regulator.
> 
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com>
> ---
>  Documentation/devicetree/bindings/regulator/pwm-regulator.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
> index bf85aa9ad6a7..3d78d507e29f 100644
> --- a/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
> +++ b/Documentation/devicetree/bindings/regulator/pwm-regulator.txt
> @@ -71,7 +71,7 @@ Continuous Voltage With Enable GPIO Example:
>  		 * Inverted PWM logic, and the duty cycle range is limited
>  		 * to 30%-70%.
>  		 */
> -		pwm-dutycycle-range <700 300>; /* */
> +		pwm-dutycycle-range = <700 300>; /* */

What's the point of "/* */" while you're here?

In any case,

Acked-by: Rob Herring <robh@...nel.org>