linux-kernel - [PATCH v2] w1:fix byteorder of W1_READ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 19 Jul 2017 16:08:00 +0800
From:   Chen Lin <chen.lin5@....com.cn>
To:     linux-kernel@...r.kernel.org
Cc:     zbr@...emap.net, jiang.biao2@....com.cn, chen.lin5@....com.cn
Subject: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu

The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must 
be the same with the byterorder defined in struct w1_reg_num. 

The rn read from 'rv = w1_read_block(dev, (u8 *)&rn, 8)' is a byte 
serial and not cpu endian relative, it need to change to cpu endian 
before passed to w1_slave_found.

Signed-off-by: Chen Lin <chen.lin5@....com.cn>
Reviewed-by: Jiang Biao <jiang.biao2@....com.cn>
---
Forgot the description in v1.

---
 drivers/w1/w1.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 95ea7e6..c531545 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -979,7 +979,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb
 			mutex_unlock(&dev->bus_mutex);
 
 			if (rv == 8 && rn)
-				cb(dev, rn);
+				cb(dev, le64_to_cpu(rn));
 
 			break;
 		}
-- 
1.8.3.1