linux-kernel - Re: [PATCH v1 6/7] drm/stm: ltdc: Cleanup rename returned value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 11:31:36 +0200
From:   Benjamin Gaignard <benjamin.gaignard@...aro.org>
To:     Philippe CORNU <philippe.cornu@...com>
Cc:     Yannick Fertre <yannick.fertre@...com>,
        Vincent Abriou <vincent.abriou@...com>,
        David Airlie <airlied@...ux.ie>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Fabien Dessenne <fabien.dessenne@...com>,
        Mickael Reulier <mickael.reulier@...com>,
        Gabriel Fernandez <gabriel.fernandez@...com>,
        Ludovic Barre <ludovic.barre@...com>,
        Alexandre Torgue <alexandre.torgue@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>
Subject: Re: [PATCH v1 6/7] drm/stm: ltdc: Cleanup rename returned value

2017-07-18 12:20 GMT+02:00 Philippe CORNU <philippe.cornu@...com>:

Commit message is missing here


> Signed-off-by: Philippe CORNU <philippe.cornu@...com>
> ---
>  drivers/gpu/drm/stm/ltdc.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index f4ed21a..8cd1b9b 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -760,7 +760,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>         struct ltdc_device *ldev = ddev->dev_private;
>         struct drm_plane *primary, *overlay;
>         unsigned int i;
> -       int res;
> +       int ret;
>
>         primary = ltdc_plane_create(ddev, DRM_PLANE_TYPE_PRIMARY);
>         if (!primary) {
> @@ -768,9 +768,9 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>                 return -EINVAL;
>         }
>
> -       res = drm_crtc_init_with_planes(ddev, crtc, primary, NULL,
> +       ret = drm_crtc_init_with_planes(ddev, crtc, primary, NULL,
>                                         &ltdc_crtc_funcs, NULL);
> -       if (res) {
> +       if (ret) {
>                 DRM_ERROR("Can not initialize CRTC\n");
>                 goto cleanup;
>         }
> @@ -783,7 +783,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>         for (i = 1; i < ldev->caps.nb_layers; i++) {
>                 overlay = ltdc_plane_create(ddev, DRM_PLANE_TYPE_OVERLAY);
>                 if (!overlay) {
> -                       res = -ENOMEM;
> +                       ret = -ENOMEM;
>                         DRM_ERROR("Can not create overlay plane %d\n", i);
>                         goto cleanup;
>                 }
> @@ -793,7 +793,7 @@ static int ltdc_crtc_init(struct drm_device *ddev, struct drm_crtc *crtc)
>
>  cleanup:
>         ltdc_plane_destroy_all(ddev);
> -       return res;
> +       return ret;
>  }
>
>  /*
> --
> 1.9.1
>



-- 
Benjamin Gaignard

Graphic Study Group

Linaro.org │ Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog