linux-kernel - Re: [PATCH][next] x86/hyper-v: add missing void return type to hyperv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 11:42:21 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Colin King <colin.king@...onical.com>,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        "K . Y . Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H . Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] x86/hyper-v: add missing void return type to
 hyperv_cleanup declaration


* Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:

> On Thu, Jul 20, 2017 at 10:52:36AM +0200, Ingo Molnar wrote:
> > 
> > * Colin King <colin.king@...onical.com> wrote:
> > 
> > > From: Colin Ian King <colin.king@...onical.com>
> > > 
> > > Add in missing void return type, fixes sparse warning:
> > > "warning: 'hyperv_cleanup()' has implicit return type"
> > > 
> > > Fixes: 2e252fbf777d ("x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set")
> > > Signed-off-by: Colin Ian King <colin.king@...onical.com>
> > > ---
> > >  arch/x86/include/asm/mshyperv.h | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/arch/x86/include/asm/mshyperv.h b/arch/x86/include/asm/mshyperv.h
> > > index 01b9c0fb3aab..41fae263f8fa 100644
> > > --- a/arch/x86/include/asm/mshyperv.h
> > > +++ b/arch/x86/include/asm/mshyperv.h
> > > @@ -178,7 +178,7 @@ void hyperv_cleanup(void);
> > >  #else /* CONFIG_HYPERV */
> > >  static inline void hyperv_init(void) {}
> > >  static inline bool hv_is_hypercall_page_setup(void) { return false; }
> > > -static inline hyperv_cleanup(void) {}
> > > +static inline void hyperv_cleanup(void) {}
> > >  #endif /* CONFIG_HYPERV */
> > 
> > Guys, Greg, could we please move this commit from the drivers tree:
> > 
> >   2e252fbf777d: x86/hyper-v: include hyperv/ only when CONFIG_HYPERV is set
> > 
> >   arch/x86/Kbuild                 | 2 +-
> >   arch/x86/include/asm/mshyperv.h | 7 ++++++-
> > 
> > ... to the x86 tree where it belongs?
> 
> I've now reverted it from my tree entirely, sorry about that.

No problem - I'll pick up the fixed v2 version when it's posted.

Thanks,

	Ingo