linux-kernel - Re: [PATCH] watchdog: imx2_wdt: use new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Jul 2017 11:22:16 +0800
From:   yjin <yanjiang.jin@...driver.com>
To:     Guenter Roeck <linux@...ck-us.net>, <wim@...ana.be>
CC:     <jinyanjiang@...il.com>, <linux-watchdog@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] watchdog: imx2_wdt: use new_timeout value to override the
 old



On 2017年07月20日 11:18, Guenter Roeck wrote:
> On 07/19/2017 07:45 PM, yanjiang.jin@...driver.com wrote:
>> From: Yanjiang Jin <yanjiang.jin@...driver.com>
>>
>> Without this patch we couldn't change the timeout value of imx2_wdt.
>>
>> Signed-off-by: Yanjiang Jin <yanjiang.jin@...driver.com>
>> ---
>>   drivers/watchdog/imx2_wdt.c | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/watchdog/imx2_wdt.c b/drivers/watchdog/imx2_wdt.c
>> index 4874b0f..6cfeee6 100644
>> --- a/drivers/watchdog/imx2_wdt.c
>> +++ b/drivers/watchdog/imx2_wdt.c
>> @@ -178,6 +178,9 @@ static int imx2_wdt_set_timeout(struct 
>> watchdog_device *wdog,
>>         regmap_update_bits(wdev->regmap, IMX2_WDT_WCR, IMX2_WDT_WCR_WT,
>>                  WDOG_SEC_TO_COUNT(new_timeout));
>> +
>> +    wdog->timeout = new_timeout;
>> +
>
> I must be missing something. That very same code is already in line 177,
> added with commit 30dd4a8f08b57 ("watchdog: imx2_wdt: also set 
> wdog->timeout
> to new_timeout") back in 2015.
>
> Did you see this in an older kernel, maybe ?

Oh, I missed this. I did use the older kernel to validate it. Thanks for 
your reminder, please ignore my patch.
Thanks again!

Regards!
Yanjiang
>
> Guenter