linux-kernel - Re: [PATCH] PM / Domains: Convert to using %pOF instead of full

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2017 09:56:52 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Rob Herring <robh@...nel.org>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        Kevin Hilman <khilman@...nel.org>, Pavel Machek <pavel@....cz>,
        Len Brown <len.brown@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] PM / Domains: Convert to using %pOF instead of full_name

On 18 July 2017 at 23:42, Rob Herring <robh@...nel.org> wrote:
> Now that we have a custom printf format specifier, convert users of
> full_name to use %pOF instead. This is preparation to remove storing
> of the full path string for each node.
>
> Signed-off-by: Rob Herring <robh@...nel.org>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> Cc: Kevin Hilman <khilman@...nel.org>
> Cc: Ulf Hansson <ulf.hansson@...aro.org>
> Cc: Pavel Machek <pavel@....cz>
> Cc: Len Brown <len.brown@...el.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: linux-pm@...r.kernel.org

Acked-by: Ulf Hansson <ulf.hansson@...aro.org>

Kind regards
Uffe

> ---
>  drivers/base/power/domain.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 3b8210ebb50e..d0989f9b5e67 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -1743,7 +1743,7 @@ static int genpd_add_provider(struct device_node *np, genpd_xlate_t xlate,
>         mutex_lock(&of_genpd_mutex);
>         list_add(&cp->link, &of_genpd_providers);
>         mutex_unlock(&of_genpd_mutex);
> -       pr_debug("Added domain provider from %s\n", np->full_name);
> +       pr_debug("Added domain provider from %pOF\n", np);
>
>         return 0;
>  }
> @@ -2149,16 +2149,16 @@ static int genpd_parse_state(struct genpd_power_state *genpd_state,
>         err = of_property_read_u32(state_node, "entry-latency-us",
>                                                 &entry_latency);
>         if (err) {
> -               pr_debug(" * %s missing entry-latency-us property\n",
> -                                               state_node->full_name);
> +               pr_debug(" * %pOF missing entry-latency-us property\n",
> +                                               state_node);
>                 return -EINVAL;
>         }
>
>         err = of_property_read_u32(state_node, "exit-latency-us",
>                                                 &exit_latency);
>         if (err) {
> -               pr_debug(" * %s missing exit-latency-us property\n",
> -                                               state_node->full_name);
> +               pr_debug(" * %pOF missing exit-latency-us property\n",
> +                                               state_node);
>                 return -EINVAL;
>         }
>
> @@ -2212,8 +2212,8 @@ int of_genpd_parse_idle_states(struct device_node *dn,
>                 ret = genpd_parse_state(&st[i++], np);
>                 if (ret) {
>                         pr_err
> -                       ("Parsing idle state node %s failed with err %d\n",
> -                                                       np->full_name, ret);
> +                       ("Parsing idle state node %pOF failed with err %d\n",
> +                                                       np, ret);
>                         of_node_put(np);
>                         kfree(st);
>                         return ret;
> --
> 2.11.0
>