linux-kernel - Re: [PATCH] GFS2: fix code parameter error in inode_go

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 21 Jul 2017 09:25:07 -0400 (EDT)
From:   Bob Peterson <rpeterso@...hat.com>
To:     Wang Xibo <wang.xibo@....com.cn>
Cc:     swhiteho@...hat.com, cluster-devel@...hat.com,
        linux-kernel@...r.kernel.org, Xiao Likun <xiao.likun@....com.cn>
Subject: Re: [PATCH] GFS2: fix code parameter error in inode_go_lock

----- Original Message -----
| In inode_go_lock() function, the parameter order of list_add() is error.
| According to the define of list_add(), the first parameter is new entry
| and the second is the list head, so ip->i_trunc_list should be the
| first parameter and the sdp->sd_trunc_list should be second.
| 
| Signed-off-by: Wang Xibo<wang.xibo@....com.cn>
| Signed-off-by: Xiao Likun<xiao.likun@....com.cn>
| ---
|  fs/gfs2/glops.c | 2 +-
|  1 file changed, 1 insertion(+), 1 deletion(-)
| 
| diff --git a/fs/gfs2/glops.c b/fs/gfs2/glops.c
| index 5e69636..28c203a 100644
| --- a/fs/gfs2/glops.c
| +++ b/fs/gfs2/glops.c
| @@ -470,7 +470,7 @@ static int inode_go_lock(struct gfs2_holder *gh)
|  	    (gh->gh_state == LM_ST_EXCLUSIVE)) {
|  		spin_lock(&sdp->sd_trunc_lock);
|  		if (list_empty(&ip->i_trunc_list))
| -			list_add(&sdp->sd_trunc_list, &ip->i_trunc_list);
| +			list_add(&ip->i_trunc_list, &sdp->sd_trunc_list);
|  		spin_unlock(&sdp->sd_trunc_lock);
|  		wake_up(&sdp->sd_quota_wait);
|  		return 1;
| --
| 1.8.3.1
| 
| 
| 
Hi,

Good catch! This is now applied to the for-next branch of the linux-gfs2 tree:
https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=e7cb550d79fba5876616ed33ccafafc4e2bd7e2e

Regards,

Bob Peterson
Red Hat File Systems