linux-kernel - [PATCH] staging: net: wireless: fix badzero.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Jul 2017 16:25:28 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Quentin Schulz <quentin.schulz@...e-electrons.com>
Cc:     kbuild-all@...org, ulf.hansson@...aro.org,
        gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        hdegoede@...hat.com, baolin.wang@...aro.org,
        linus.walleij@...aro.org, linux-mmc@...r.kernel.org,
        adrian.hunter@...el.com, linux-kernel@...r.kernel.org,
        Quentin Schulz <quentin.schulz@...e-electrons.com>,
        wens@...e.org, icenowy@...c.xyz, maxime.ripard@...e-electrons.com,
        shawn.lin@...k-chips.com
Subject: [PATCH] staging: net: wireless: fix badzero.cocci warnings

drivers/staging/esp8089/esp_mac80211.c:596:33-34: WARNING comparing pointer to 0

 Compare pointer-typed values to NULL rather than 0

Semantic patch information:
 This makes an effort to choose between !x and x == NULL.  !x is used
 if it has previously been used with the function used to initialize x.
 This relies on type information.  More type information can be obtained
 using the option -all_includes and the option -I to specify an
 include path.

Generated by: scripts/coccinelle/null/badzero.cocci

Fixes: 5ebdb57b0b15 ("staging: net: wireless: add ESP8089 WiFi driver")
CC: Quentin Schulz <quentin.schulz@...e-electrons.com>
Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
---

 esp_mac80211.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/staging/esp8089/esp_mac80211.c
+++ b/drivers/staging/esp8089/esp_mac80211.c
@@ -593,7 +593,7 @@ static void hw_scan_timeout_report(struc
 	if (test_and_clear_bit(ESP_WL_FLAG_STOP_TXQ, &epub->wl.flags))
 		sip_trigger_txq_process(epub->sip);
 	/*check if normally complete or aborted like timeout/hw error */
-	aborted = (epub->wl.scan_req != 0);
+	aborted = (epub->wl.scan_req != NULL);
 
 	if (aborted)
 		epub->wl.scan_req = NULL;