linux-kernel - [PATCH-next] IB/hns: fix implicit irq include causing build fails in roce

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Sun, 23 Jul 2017 09:53:45 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     <linux-kernel@...r.kernel.org>
CC:     <linux-next@...r.kernel.org>,
        Paul Gortmaker <paul.gortmaker@...driver.com>,
        Lijun Ou <oulijun@...wei.com>,
        "Wei Hu(Xavier)" <xavier.huwei@...wei.com>,
        Doug Ledford <dledford@...hat.com>,
        Sean Hefty <sean.hefty@...el.com>,
        Hal Rosenstock <hal.rosenstock@...il.com>,
        <linux-rdma@...r.kernel.org>
Subject: [PATCH-next] IB/hns: fix implicit irq include causing build fails in roce_eq

To fix:

drivers/infiniband/hw/hns/hns_roce_eq.c:477:1: error: unknown type name ‘irqreturn_t’
 static irqreturn_t hns_roce_msi_x_interrupt(int irq, void *eq_ptr)
 ^
drivers/infiniband/hw/hns/hns_roce_eq.c: In function ‘hns_roce_msi_x_interrupt’:
drivers/infiniband/hw/hns/hns_roce_eq.c:485:2: error: implicit declaration of function ‘IRQ_RETVAL’ [-Werror=implicit-function-declaration]
  return IRQ_RETVAL(int_work);
  ^
drivers/infiniband/hw/hns/hns_roce_eq.c: In function ‘hns_roce_init_eq_table’:
drivers/infiniband/hw/hns/hns_roce_eq.c:711:3: error: implicit declaration of function ‘request_irq’ [-Werror=implicit-function-declaration]
   ret = request_irq(eq_table->eq[j].irq, hns_roce_msi_x_interrupt,
   ^
drivers/infiniband/hw/hns/hns_roce_eq.c:726:3: error: implicit declaration of function ‘free_irq’ [-Werror=implicit-function-declaration]
   free_irq(eq_table->eq[j].irq, eq_table->eq + j);
   ^

as seen on arm64 allmodconfig builds.

Cc: Lijun Ou <oulijun@...wei.com>
Cc: "Wei Hu(Xavier)" <xavier.huwei@...wei.com>
Cc: Doug Ledford <dledford@...hat.com>
Cc: Sean Hefty <sean.hefty@...el.com>
Cc: Hal Rosenstock <hal.rosenstock@...il.com>
Cc: linux-rdma@...r.kernel.org
Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
---

[ Seen on current linux-next tree. ]

 drivers/infiniband/hw/hns/hns_roce_eq.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/hns/hns_roce_eq.c b/drivers/infiniband/hw/hns/hns_roce_eq.c
index 50f864935a0e..e1e4c16ca3d5 100644
--- a/drivers/infiniband/hw/hns/hns_roce_eq.c
+++ b/drivers/infiniband/hw/hns/hns_roce_eq.c
@@ -30,6 +30,7 @@
  * SOFTWARE.
  */
 
+#include <linux/interrupt.h>
 #include <linux/platform_device.h>
 #include "hns_roce_common.h"
 #include "hns_roce_device.h"
-- 
2.11.0