linux-kernel - RE: [PATCH] qe: fix compile issue for arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2017 02:09:23 +0000
From:   Qiang Zhao <qiang.zhao@....com>
To:     Michael Ellerman <mpe@...erman.id.au>,
        "oss@...error.net" <oss@...error.net>
CC:     "valentin.longchamp@...mile.com" <valentin.longchamp@...mile.com>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] qe: fix compile issue for arm64

On Fri, 2017-07-21 at 02:34PM, Michael Ellerman <mpe@...erman.id.au> wrote:

> -----Original Message-----
> From: Michael Ellerman [mailto:mpe@...erman.id.au]
> Sent: Friday, July 21, 2017 2:34 PM
> To: Qiang Zhao <qiang.zhao@....com>; oss@...error.net
> Cc: valentin.longchamp@...mile.com; linuxppc-dev@...ts.ozlabs.org; linux-
> kernel@...r.kernel.org; Qiang Zhao <qiang.zhao@....com>
> Subject: Re: [PATCH] qe: fix compile issue for arm64
> 
> Zhao Qiang <qiang.zhao@....com> writes:
> 
> > Signed-off-by: Zhao Qiang <qiang.zhao@....com>
> > ---
> >  drivers/soc/fsl/qe/qe.c | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c index
> > 2ef6fc6..d48fa4a 100644
> > --- a/drivers/soc/fsl/qe/qe.c
> > +++ b/drivers/soc/fsl/qe/qe.c
> > @@ -229,7 +229,9 @@ int qe_setbrg(enum qe_clock brg, unsigned int rate,
> unsigned int multiplier)
> >  	/* Errata QE_General4, which affects some MPC832x and MPC836x
> SOCs, says
> >  	   that the BRG divisor must be even if you're not using divide-by-16
> >  	   mode. */
> > +#ifdef CONFIG_PPC
> >  	if (pvr_version_is(PVR_VER_836x) || pvr_version_is(PVR_VER_832x)
> > +#endif
> >  		if (!div16 && (divisor & 1) && (divisor > 3))
> >  			divisor++;
> 
> Are you sure that's what you want to do on arm64 ?

Is there any problem?

Best Regards
Qiang Zhao