linux-kernel - Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek MT6380 regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Jul 2017 13:22:42 -0500
From:   Rob Herring <robh@...nel.org>
To:     sean.wang@...iatek.com
Cc:     matthias.bgg@...il.com, mark.rutland@....com, lgirdwood@...il.com,
        broonie@...nel.org, jamesjj.liao@...iatek.com,
        henryc.chen@...iatek.com, devicetree@...r.kernel.org,
        linux-mediatek@...ts.infradead.org, chen.zhong@...iatek.com,
        chenglin.xu@...iatek.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/9] dt-bindings: regulator: Add document for MediaTek
 MT6380 regulator

On Tue, Jul 18, 2017 at 05:49:22PM +0800, sean.wang@...iatek.com wrote:
> From: Sean Wang <sean.wang@...iatek.com>
> 
> add dt-binding document for MediaTek MT6380 PMIC
> 
> Signed-off-by: Chenglin Xu <chenglin.xu@...iatek.com>
> Signed-off-by: Sean Wang <sean.wang@...iatek.com>
> ---
>  .../bindings/regulator/mt6380-regulator.txt        | 90 ++++++++++++++++++++++
>  1 file changed, 90 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> 
> diff --git a/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> new file mode 100644
> index 0000000..2a559f0
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/regulator/mt6380-regulator.txt
> @@ -0,0 +1,90 @@
> +MediaTek MT6380 Regulator Driver

Bindings don't describe drivers.

> +
> +All voltage regulators are defined as subnodes of the regulators node. A list

What's the regulators node a child of?

> +of regulators provided by this controller are defined as subnodes of the
> +PMIC's node. Each regulator is named according to its regulator type,
> +buck-<name> and ldo-<name>. The definition for each of these nodes is defined
> +using the standard binding for regulators at
> +Documentation/devicetree/bindings/regulator/regulator.txt.
> +
> +The valid names for regulators are:
> +BUCK:
> +  buck-core1, buck-vcore, buck-vrf
> +LDO:
> +  ldo-vm ,ldo-va , ldo-vphy, ldo-vddr, ldo-vt