linux-kernel - Re: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and simplify hotplug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 25 Jul 2017 09:27:55 -0400 (EDT)
From:   Chad Dupuis <chad.dupuis@...ium.com>
To:     Thomas Gleixner <tglx@...utronix.de>
cc:     LKML <linux-kernel@...r.kernel.org>,
        QLogic-Storage-Upstream@...gic.com, martin.petersen@...cle.com,
        James Bottomley <James.Bottomley@...senPartnership.com>,
        linux-scsi <linux-scsi@...r.kernel.org>,
        Christoph Hellwig <hch@....de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [patch 0/5] scsi/bnx2*: Plug hotplug race, correct locking and
 simplify hotplug code


On Mon, 24 Jul 2017, 6:52am, Thomas Gleixner wrote:

> The conversion of the cpu hotplug locking to a percpu rwsem does not longer
> allow recursive locking of the hotplug lock.
> 
> The BNX2I and BNX2FC drivers install/remove hotplug states with the hotplug
> lock held. The install/removal code acquired the hotplug lock as well.
> 
> While looking into this, I noticed an interesting hotplug race in the
> BNX2FC driver, which could result in dereferencing a NULL pointer or freed
> and potentially reused memory.
> 
> The following series addresses these problems and as a final step on top it
> simplifies the hotplug code in both drivers.
> 
> Thanks,
> 
> 	tglx
> 
> ----
>  drivers/scsi/bnx2fc/bnx2fc_fcoe.c |   68 ++++++++------------------------------
>  drivers/scsi/bnx2fc/bnx2fc_hwi.c  |   45 ++++++++++++-------------
>  drivers/scsi/bnx2i/bnx2i_init.c   |   64 ++++++++---------------------------
>  include/linux/cpuhotplug.h        |    2 -
>  4 files changed, 53 insertions(+), 126 deletions(-)
> 

We tested the series and everything was fine.  Ack to the series.

Acked-by: Chad Dupuis <chad.dupuis@...ium.com>