linux-kernel - Re: [PATCH v2] smp_call_function: use inline helpers instead of macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 26 Jul 2017 16:50:20 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Ralf Baechle <ralf@...ux-mips.org>,
        James Hogan <james.hogan@...tec.com>,
        Paul Burton <paul.burton@...tec.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juergen Gross <jgross@...e.com>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        "open list:RALINK MIPS ARCHITECTURE" <linux-mips@...ux-mips.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] smp_call_function: use inline helpers instead of macros

On Wed, Jul 26, 2017 at 4:42 PM, Paolo Bonzini <pbonzini@...hat.com> wrote:
> On 26/07/2017 15:32, Arnd Bergmann wrote:
>> A new caller of smp_call_function() passes a local variable as the 'wait'
>> argument, and that variable is otherwise unused, so we get a warning
>> in non-SMP configurations:
>>
>> virt/kvm/kvm_main.c: In function 'kvm_make_all_cpus_request':
>> virt/kvm/kvm_main.c:195:7: error: unused variable 'wait' [-Werror=unused-variable]
>>   bool wait = req & KVM_REQUEST_WAIT;
>>
>> This addresses the warning by changing the two macros into inline functions.
>> As reported by the 0day build bot, a small change is required in the MIPS
>> r4k code for this, which then gets a warning about a missing variable.
>>
>> Fixes: 7a97cec26b94 ("KVM: mark requests that need synchronization")
>> Cc: Paolo Bonzini <pbonzini@...hat.com>
>> Link: https://patchwork.kernel.org/patch/9722063/
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> This is not needed anymore, I've fixed it in KVM:
>
>     commit b49defe83659cefbb1763d541e779da32594ab10
>     Author: Paolo Bonzini <pbonzini@...hat.com>
>     Date:   Fri Jun 30 13:25:45 2017 +0200
>
>     kvm: avoid unused variable warning for UP builds

Ok, that seems sufficient, thanks!

      Arnd