linux-kernel - Re: [PATCH] turbostat: Running on virtual machine is not supported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 26 Jul 2017 23:09:18 -0400
From:   Len Brown <lenb@...nel.org>
To:     Henrique de Moraes Holschuh <hmh@....eng.br>
Cc:     Prarit Bhargava <prarit@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Len Brown <len.brown@...el.com>
Subject: Re: [PATCH] turbostat: Running on virtual machine is not supported

Henrique,

I like your suggestion, thanks!

BTW. let's discuss (and patch) turbostat on linux-pm, rather than on lkml.

thanks,
-Len


On Tue, Jul 25, 2017 at 11:59 AM, Henrique de Moraes Holschuh
<hmh@....eng.br> wrote:
> On Tue, 25 Jul 2017, Prarit Bhargava wrote:
>> A common way of determining if the system is a virtual machine is to
>> search /proc/cpuinfo flags entry for "hypervisor".  turbostat must output
>> a proper error message when found.
>
> Maybe you could output that message only if it fails to both use
> /dev/msr and perf *and* it is under a virtual machine?  That would have
> better forward compatibility, maybe someday /dev/msr or perf will work
> inside a VM for what turbostat needs...
>
> --
>   Henrique Holschuh



-- 
Len Brown, Intel Open Source Technology Center