linux-kernel - Re: [greybus-dev] [PATCH] staging: greybus: Remove unnecessary platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 27 Jul 2017 10:39:02 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:     hvaibhav.linux@...il.com, johan@...nel.org, elder@...nel.org,
        gregkh@...uxfoundation.org, greybus-dev@...ts.linaro.org,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [greybus-dev] [PATCH] staging: greybus: Remove unnecessary
 platform_set_drvdata

On 26-07-17, 23:19, Amitoj Kaur Chawla wrote:
> Unnecessary platform_set_drvdata() has been removed since the driver
> core clears the driver data to NULL after device release or on
> probe failure. There is no need to manually clear the device
> driver data to NULL.
> 
> The Coccinelle semantic patch used to make this change is as follows:
> //<smpl>
> @@
> struct platform_device *pdev;
> @@
> - platform_set_drvdata(pdev, NULL);
> //</smpl>
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
>  drivers/staging/greybus/arche-platform.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/greybus/arche-platform.c b/drivers/staging/greybus/arche-platform.c
> index eced2d2..358b260 100644
> --- a/drivers/staging/greybus/arche-platform.c
> +++ b/drivers/staging/greybus/arche-platform.c
> @@ -607,7 +607,6 @@ static int arche_platform_remove(struct platform_device *pdev)
>  	device_remove_file(&pdev->dev, &dev_attr_state);
>  	device_for_each_child(&pdev->dev, NULL, arche_remove_child);
>  	arche_platform_poweroff_seq(arche_pdata);
> -	platform_set_drvdata(pdev, NULL);
>  
>  	if (usb3613_hub_mode_ctrl(false))
>  		dev_warn(arche_pdata->dev, "failed to control hub device\n");

Acked-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh