linux-kernel - Re: [PATCH] init:main.c: Fixed issues in Block comments and removed braces in single statement if block

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 08:23:59 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     janani-sankarababu <jananis37@...il.com>
Cc:     mingo@...nel.org, akpm@...ux-foundation.org, keescook@...omium.org,
        jeyu@...hat.com, tglx@...utronix.de, viresh.kumar@...aro.org,
        tj@...nel.org, prarit@...hat.com, lokeshvutla@...com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init:main.c: Fixed issues in Block comments and removed
 braces in single statement if block

On Fri, 28 Jul 2017 11:37:33 +0530
janani-sankarababu <jananis37@...il.com> wrote:

> Signed-off-by: Janani S <jananis37@...il.com>
> 
> ---
>  init/main.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/init/main.c b/init/main.c
> index 052481f..f8eb4966 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -181,7 +181,8 @@ static bool __init obsolete_checksetup(char *line)
>  				/* Already done in parse_early_param?
>  				 * (Needs exact match on param part).
>  				 * Keep iterating, as we can have early
> -				 * params and __setups of same names 8( */
> +				 * params and __setups of same names

Why did you get rid of the "8(" part? Yeah, it's a kind of an old
fashion emoji, but it helps make the code stand out as something that
we can improve on in the future.

> +				 */
>  				if (line[n] == '\0' || line[n] == '=')
>  					had_early_param = true;
>  			} else if (!p->setup_func) {
> @@ -693,9 +694,9 @@ asmlinkage __visible void __init start_kernel(void)
>  	arch_post_acpi_subsys_init();
>  	sfi_init_late();
>  
> -	if (efi_enabled(EFI_RUNTIME_SERVICES)) {
> +	if (efi_enabled(EFI_RUNTIME_SERVICES))
>  		efi_free_boot_services();
> -	}
> +

Honestly, I'm not too thrilled with these patches. It causes churn to
the code history with very little benefit. Usually these types of clean
ups are done when the code is modified for functional reasons.

Brackets for single instruction blocks isn't needed. But it's not
something we should go out of our way to "fix".

-- Steve


>  
>  	/* Do the rest non-__init'ed, we're now alive */
>  	rest_init();