linux-kernel - Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jul 2017 14:25:07 -0700
From:   Deepa Dinamani <deepa.kernel@...il.com>
To:     Paul Moore <paul@...l-moore.com>
Cc:     Alexander Viro <viro@...iv.linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        Richard Guy Briggs <rgb@...hat.com>
Subject: Re: [RESEND PATCH 2/6] ipc: mqueue: Replace timespec with timespec64

>> -               memcpy(p, abs_timeout, sizeof(struct timespec));
>> +               memcpy(p, abs_timeout, sizeof(struct timespec64));
>
> Since you're changing this line, how about changing it to the following:
>
>   memcpy(p, abs_timeout, sizeof(*p));
>
>>         else
>> -               memset(p, 0, sizeof(struct timespec));
>> +               memset(p, 0, sizeof(struct timespec64));
>
> Same here.

Sure, that seems fine to me.
I will post an update.

-Deepa