linux-kernel - Re: [PATCH v2 3/6] ipc: msg: Make msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jul 2017 16:14:34 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Deepa Dinamani <deepa.kernel@...il.com>
Cc:     Al Viro <viro@...iv.linux.org.uk>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>
Subject: Re: [PATCH v2 3/6] ipc: msg: Make msg_queue timestamps y2038 safe

On Mon, Jul 31, 2017 at 12:30 AM, Deepa Dinamani <deepa.kernel@...il.com> wrote:
> @@ -1181,7 +1181,7 @@ static int sysvipc_msg_proc_show(struct seq_file *s, void *it)
>         struct msg_queue *msq = it;
>
>         seq_printf(s,
> -                  "%10d %10d  %4o  %10lu %10lu %5u %5u %5u %5u %5u %5u %10lu %10lu %10lu\n",
> +                  "%10d %10d  %4o  %10lu %10lu %5u %5u %5u %5u %5u %5u %10llu %10llu %10llu\n",
>                    msq->q_perm.key,
>                    msq->q_perm.id,
>                    msq->q_perm.mode,
> @@ -1193,9 +1193,9 @@ static int sysvipc_msg_proc_show(struct seq_file *s, void *it)
>                    from_kgid_munged(user_ns, msq->q_perm.gid),
>                    from_kuid_munged(user_ns, msq->q_perm.cuid),
>                    from_kgid_munged(user_ns, msq->q_perm.cgid),
> -                  msq->q_stime,
> -                  msq->q_rtime,
> -                  msq->q_ctime);
> +                  (unsigned long long) msq->q_stime,
> +                  (unsigned long long) msq->q_rtime,
> +                  (unsigned long long) msq->q_ctime);
>
>         return 0;

This again can skip the cast, you only need the format change.

       Arnd