linux-kernel - Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 01 Aug 2017 01:11:31 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     Andy Yan <andy.yan@...k-chips.com>
Cc:     devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, robh+dt@...nel.org
Subject: Re: [PATCH 11/14] ARM: dts: rockchip: add saradc support for rv1108

Hi Andy,

Am Montag, 31. Juli 2017, 18:19:19 CEST schrieb Andy Yan:
> Add saradc device tree node for rv1108
> 
> Signed-off-by: Andy Yan <andy.yan@...k-chips.com>
> ---
> 
>  arch/arm/boot/dts/rv1108.dtsi | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/rv1108.dtsi b/arch/arm/boot/dts/rv1108.dtsi
> index 1fc467e..958fecd 100644
> --- a/arch/arm/boot/dts/rv1108.dtsi
> +++ b/arch/arm/boot/dts/rv1108.dtsi
> @@ -275,6 +275,18 @@
>  		status = "disabled";
>  	};
>  
> +	adc: adc@...8c000 {
> +		compatible = "rockchip,rk3399-saradc";

you should amend the binding txt to make this something like
compatible = "rockchip,rv1108-saradc", "rockchip,rk3399-saradc"

See for example the bindings/mmc/rockchip-dw-mshc.txt as inspiration.

Heiko