lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Aug 2017 10:45:54 +1000 (AEST) From: James Morris <jmorris@...ei.org> To: Kees Cook <keescook@...omium.org> cc: Andrew Morton <akpm@...ux-foundation.org>, Stephen Smalley <sds@...ho.nsa.gov>, David Howells <dhowells@...hat.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, John Johansen <john.johansen@...onical.com>, "Serge E. Hallyn" <serge@...lyn.com>, Paul Moore <paul@...l-moore.com>, Casey Schaufler <casey@...aufler-ca.com>, Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, James Morris <james.l.morris@...cle.com>, Andy Lutomirski <luto@...nel.org>, Linus Torvalds <torvalds@...ux-foundation.org>, linux-fsdevel@...r.kernel.org, linux-security-module@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v4 05/15] selinux: Refactor to remove bprm_secureexec hook On Mon, 31 Jul 2017, Kees Cook wrote: > The SELinux bprm_secureexec hook can be merged with the bprm_set_creds > hook since it's dealing with the same information, and all of the details > are finalized during the first call to the bprm_set_creds hook via > prepare_binprm() (subsequent calls due to binfmt_script, etc, are ignored > via bprm->called_set_creds). > > Here, the test can just happen at the end of the bprm_set_creds hook, > and the bprm_secureexec hook can be dropped. > > Cc: Stephen Smalley <sds@...ho.nsa.gov> > Signed-off-by: Kees Cook <keescook@...omium.org> > Acked-by: Paul Moore <paul@...l-moore.com> > Tested-by: Paul Moore <paul@...l-moore.com> > Acked-by: Serge Hallyn <serge@...lyn.com> > --- > security/selinux/hooks.c | 24 +++++------------------- > 1 file changed, 5 insertions(+), 19 deletions(-) Reviewed-by: James Morris <james.l.morris@...cle.com> -- James Morris <jmorris@...ei.org>
Powered by blists - more mailing lists