linux-kernel - Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2017 09:55:56 +0200
From:   Johannes Thumshirn <jthumshirn@...e.de>
To:     Hannes Reinecke <hare@...e.de>
Cc:     Suganath Prabu S <suganath-prabu.subramani@...adcom.com>,
        jejb@...nel.org, hch@...radead.org, martin.petersen@...cle.com,
        linux-scsi@...r.kernel.org, Sathya.Prakash@...adcom.com,
        kashyap.desai@...adcom.com, linux-kernel@...r.kernel.org,
        chaitra.basappa@...adcom.com, sreekanth.reddy@...adcom.com,
        linux-nvme@...ts.infradead.org
Subject: Re: [PATCH v2 01/13] mpt3sas: Update MPI Header

On Thu, Aug 03, 2017 at 08:24:59AM +0200, Hannes Reinecke wrote:
> > +	U32
> > +		IOCLogInfo;                     /*0x10 */
> > +	U16
> > +		ErrorResponseCount;             /*0x14 */
> > +	U16
> > +		Reserved4;                      /*0x16 */
> > +} MPI26_NVME_ENCAPSULATED_ERROR_REPLY,
> > +	*PTR_MPI26_NVME_ENCAPSULATED_ERROR_REPLY,
> > +	Mpi26NVMeEncapsulatedErrorReply_t,
> > +	*pMpi26NVMeEncapsulatedErrorReply_t;
> > +
> > +
> > +#endif
> > +
> > +
> Very odd indentation.
> Please reformat to have type and variable on one line.

And use Linux types and no CamelCase and no typedefs (especially not for
pointers), you're not on Windows here.

Thanks,
	Johannes

-- 
Johannes Thumshirn                                          Storage
jthumshirn@...e.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850