linux-kernel - Re: [PATCH v2 4/5] dt-bindings: phy-rockchip-inno-usb2: add otg mux irq quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2017 09:47:37 +0800
From:   Frank Wang <frank.wang@...k-chips.com>
To:     Heiko Stübner <heiko@...ech.de>
Cc:     kishon@...com, robh+dt@...nel.org, mark.rutland@....com,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
        linux-rockchip@...ts.infradead.org, huangtao@...k-chips.com,
        william.wu@...k-chips.com, daniel.meng@...k-chips.com,
        kever.yang@...k-chips.com, andy.yan@...k-chips.com,
        wmc@...k-chips.com
Subject: Re: [PATCH v2 4/5] dt-bindings: phy-rockchip-inno-usb2: add otg mux
 irq quirk

Hi Heiko,

On 2017/8/2 19:25, Heiko Stübner wrote:
> Hi Frank,
>
> Am Mittwoch, 2. August 2017, 15:53:09 CEST schrieb Frank Wang:
>> Add rockchip,otg_mux_irq_quirk property to support the otg-id/
>> otg-bvalid/linestate irqs that are multiplexed to one irq in
>> otg-port on some special Rockchip SoCs (e.g RV1108).
>>
>> Signed-off-by: Frank Wang <frank.wang@...k-chips.com>
>> ---
>>   Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
>> b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt index
>> ddf868a..d49572b 100644
>> --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
>> +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt
>> @@ -22,6 +22,8 @@ Optional properties:
>>   		 register files".
>>    - rockchip,companion_grf_quirk : when set driver will request
>>   		 "rockchip,usbgrf" phandle as one companion-grf.
>> + - rockchip,otg_mux_irq_quirk: set if otg-id/otg-bvalid/linestate irqs
>> +		 are multiplexed to one irq in otg-port on some SoCs.
>>
>>   Required nodes : a sub-node is required for each port the phy provides.
>>   		 The sub-node name is used to identify host or otg port,
>> @@ -36,6 +38,9 @@ Required properties (port (child) node):
>>   	* "otg-id" : for the otg id interrupt.
>>   	* "otg-bvalid" : for the otg vbus interrupt.
>>   	* "linestate" : for the host/otg linestate interrupt.
>> +	* "otg-mux" : otg-port interrupt, which multiplex otg-id/otg-bvalid/
>> +		linestate irqs to one irq. Should specify if
>> +		rockchip,otg_mux_irq_quirk property is set.
> I'd think that should be auto-detectable in the driver without the quirk
> property above?
>
> I.e. check for the otg-mux interrupt first on probe and if can be found, you
> know that this is the case, otherwise look for the regular interrupts.
>
>
> Also I would write that down a bit differently, so that it doesn't confuse
> people. Something similar to:
>
>   - interrupt-names : a list which should
> +    Regular case:
> 	* "otg-id" : for the otg id interrupt.
> 	* "otg-bvalid" : for the otg vbus interrupt.
> 	* "linestate" : for the host/otg linestate interrupt.
> +    Some socs use one interrupt with the obove muxed together, so for these
> +	* "otg-mux" : otg-port interrupt, which multiplex otg-id/otg-bvalid/
> +		linestate irqs to one irq.
>
>
> Heiko
>

Thanks for your comments, I will fix it in next version.


BR.
Frank