linux-kernel - Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2017 18:29:48 +0200
From:   Martin Kaiser <martin@...ser.cx>
To:     Shawn Guo <shawnguo@...nel.org>
Cc:     Markus Pargmann <mpa@...gutronix.de>,
        Denis Carikli <denis@...rea.com>, devicetree@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>, kernel@...gutronix.de,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: i.MX25: add ranges to tscadc

Hi Shawn,

Thus wrote Shawn Guo (shawnguo@...nel.org):

> On Wed, Aug 02, 2017 at 10:06:11PM +0200, Martin Kaiser wrote:
> > Add a ranges; line to the tscadc node. This creates a 1:1 mapping between
> > the addresses used by tscadc and those in its child nodes (adc, tsc).

> > Without such a mapping, the reg = ... lines in the tsc and adc nodes do
> > not create a resource. Probing the fsl-imx25-tcq and fsl-imx25-tsadc
> > drivers will then fail since there's no IORESOURCE_MEM.

> > Signed-off-by: Martin Kaiser <martin@...ser.cx>

> Do we need the following Fixes tag?

> Fixes: 92f651f39b42 ("ARM: dts: imx25: Add TSC and ADC support")

yes, looks like this has never worked correctly.

If you're ok with the fix, I can add the tag in v2.

> @Markus, we didn't the changes when we were submitting?

Both Markus' and Denis' mail addresses bounced...

Best regards,
Martin