linux-kernel - Re: [PATCH] soc: versatile: remove unnecessary static in realview_soc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 3 Aug 2017 16:46:44 -0500
From:   "Gustavo A. R. Silva" <gustavo@...eddedor.com>
To:     Linus Walleij <linus.walleij@...aro.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] soc: versatile: remove unnecessary static in
 realview_soc_probe()



On 08/02/2017 06:59 AM, Linus Walleij wrote:
> On Thu, Jul 20, 2017 at 12:40 AM, Gustavo A. R. Silva
> <gustavo@...eddedor.com> wrote:
>
>> Remove unnecessary static on local variables syscon_regmap.
>> Such variables are initialized before being used, on every
>> execution path throughout the functions. The static has no
>> benefit and, removing it reduces the object file size.
>>
>> This issue was detected using Coccinelle and the following
>> semantic patch:
>>
>> @bad exists@
>> position p;
>> identifier x;
>> type T;
>> @@
>>
>> static T x@p;
>> ...
>> x = <+...x...+>
>>
>> @@
>> identifier x;
>> expression e;
>> type T;
>> position p != bad.p;
>> @@
>>
>> -static
>>  T x@p;
>>  ... when != x
>>      when strict
>> ?x = e;
>>
>> In the following log you can see the difference in the object file size.
>> This log is the output of the size command, before and after the code
>> change:
>>
>> before:
>>    text    data     bss     dec     hex filename
>>    3339    2104     128    5571    15c3 drivers/soc/versatile/soc-realview.o
>>
>> after:
>>    text    data     bss     dec     hex filename
>>    3321    2048      64    5433    1539 drivers/soc/versatile/soc-realview.o
>>
>> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
>
> You probably want to funnel this patch through the ARM SoC tree.
>
> (If nothing else works, send as separate patch to arm@...nel.org)
>

OK, I'll do that. I'll add your ACK and CC you.

Thanks!
-- 
Gustavo A. R. Silva