linux-kernel - Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 6 Aug 2017 22:21:11 +0200
From:   Pali Rohár <pali.rohar@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Darren Hart <dvhart@...radead.org>,
        Andy Shevchenko <andy@...radead.org>,
        David Airlie <airlied@...hat.com>,
        "Chun-Yi Lee" <jlee@...e.com>,
        Corentin Chary <corentin.chary@...il.com>,
        "acpi4asus-user" <acpi4asus-user@...ts.sourceforge.net>,
        Oleksij Rempel <linux@...pel-privat.de>,
        João Paulo Rechi Vita <jprvita@...il.com>,
        Andy Lutomirski <luto@...nel.org>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] RFC: platform/x86: wmi: Fix check for method instance number

On Sunday 06 August 2017 18:10:12 Andy Shevchenko wrote:
> On Sun, Aug 6, 2017 at 6:35 PM, Pali Rohár <pali.rohar@...il.com>
> wrote:
> > On Wednesday 05 July 2017 22:24:20 Pali Rohár wrote:
> >> On Wednesday 05 July 2017 21:30:35 David Airlie wrote:
> >> > > On Saturday 17 June 2017 18:47:54 Pali Rohár wrote:
> >> > > > > So problematic drivers which use instance=1 without any
> >> > > > > comments
> >> > > > > 
> >> > > > > are:
> >> > > > >   acer-wmi
> >> > > > >   asus-wmi
> >> > > > >   mxm-wmi
> > 
> > Hi! For mxm-wmi I found this document:
> > https://lekensteyn.nl/files/docs/mxm-2.1-software-spec.pdf
> > 
> > On page numbered 26 (resp. in PDF page 31) is information about WMI
> > GUID {F6CB5C3C-9CAE-4EBD-B577-931EA32A2CC0} interface and there is
> > written that instance count = 1.
> > 
> > // Methods GUID {F6CB5C3C-9CAE-4ebd-B577-931EA32A2CC0}
> > 0x3C, 0x5C, 0xCB, 0xF6, 0xAE, 0x9C, 0xbd, 0x4e, 0xB5, 0x77, 0x93,
> > 0x1E, 0xA3, 0x2A, 0x2C, 0xC0,
> > 0x4D, 0x58,    // Object ID “MX” = method “WMMX”
> > 1,             // Instance Count
> > 0x02,          // Flags (WMIACPI_REGFLAG_METHOD)
> > 
> > And ACPI method for handling this WMI call does not check Arg0 and
> > Arg1 at all.
> > 
> > So... Andy, Darren, any objections for following patch which
> > changes instance number from one to zero?
> 
> No objections from me! Just put enough explanation into commit
> message.

Ok.

Now I found ACPI code for asus-wmi.c GUID 
97845ED0-4E6D-11DE-8A39-0800200C9A66 on https://lwn.net/Articles/391249/ 
and there is also in _WDG buffer instance count just 1 and WMBC method 
do not check Arg0.

So asus-wmi.c needs to be fixed too.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)