lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 7 Aug 2017 10:42:05 +0800 From: Rick Chang <rick.chang@...iatek.com> To: Julia Lawall <Julia.Lawall@...6.fr> CC: <bhumirks@...il.com>, <kernel-janitors@...r.kernel.org>, Bin Liu <bin.liu@...iatek.com>, Mauro Carvalho Chehab <mchehab@...nel.org>, Matthias Brugger <matthias.bgg@...il.com>, <linux-media@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, <linux-mediatek@...ts.infradead.org>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 05/12] [media] vcodec: mediatek: constify v4l2_m2m_ops structures On Sun, 2017-08-06 at 10:25 +0200, Julia Lawall wrote: > The v4l2_m2m_ops structures are only passed as the only > argument to v4l2_m2m_init, which is declared as const. > Thus the v4l2_m2m_ops structures themselves can be const. > > Done with the help of Coccinelle. > > // <smpl> > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct v4l2_m2m_ops i@p = { ... }; > > @ok1@ > identifier r.i; > position p; > @@ > v4l2_m2m_init(&i@p) > > @bad@ > position p != {r.p,ok1.p}; > identifier r.i; > struct v4l2_m2m_ops e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct v4l2_m2m_ops i = { ... }; > // </smpl> > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Rick Chang <rick.chang@...iatek.com>
Powered by blists - more mailing lists