linux-kernel - RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 01:15:04 +0000
From:   Peng Fan <peng.fan@....com>
To:     Fabio Estevam <festevam@...il.com>
CC:     Linus Walleij <linus.walleij@...aro.org>,
        Rob Herring <robh@...nel.org>,
        "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] gpio: 74x164: handling enable-gpios

> > +       chip->enable_gpio = devm_gpiod_get(&spi->dev, "enable",
> GPIOD_OUT_LOW);
> > +       if (IS_ERR(chip->enable_gpio)) {
> > +               dev_dbg(&spi->dev, "No enable-gpios property\n");
> > +               chip->enable_gpio = NULL;
> 
> Also, the error handling here is not correct as it will never propagate
> EPROBE_DEFER.
> 
> I will submit my version of the patch if you don't mind.

That's ok if you have a better patch.

Regards,
Peng.