[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 08 Aug 2017 10:28:23 +0200
From: Oliver Neukum <oneukum@...e.com>
To: Kai-Heng Feng <kai.heng.feng@...onical.com>,
gregkh@...uxfoundation.org
Cc: stern@...land.harvard.edu, linux-kernel@...r.kernel.org,
linux-usb@...r.kernel.org
Subject: Re: [PATCH v2] usb: quirks: Add no-lpm quirk for Moshi USB to
Ethernet Adapter
Am Dienstag, den 08.08.2017, 14:32 +0800 schrieb Kai-Heng Feng:
> Moshi USB to Ethernet Adapter internally uses a Genesys Logic hub to
> connect to Realtek r8153.
>
> The Realtek r8153 ethernet does not work on the internal hub, no-lpm quirk
> can make it work.
>
> Since another r8153 dongle at my hand does not have the issue, so add
> the quirk to the hub instead.
But in the comment you say you add it to the device!
This makes no sense.
[..]
> + /* Moshi USB to Ethernet Adapter */
> + { USB_DEVICE(0x05e3, 0x0616), .driver_info = USB_QUIRK_NO_LPM },
> +
Now is this a hub or a device? If this is a Genesys Logic hub,
you need to say that clearly and state that it is an internal hub.
Regards
Oliver
Powered by blists - more mailing lists