linux-kernel - Re: [PATCH] mmc: wmt-sdmmc: Handle return value of clk_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 12:38:40 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Arvind Yadav <arvind.yadav.cs@...il.com>
Cc:     Tony Prisk <linux@...sktech.co.nz>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] mmc: wmt-sdmmc: Handle return value of clk_prepare_enable

On 8 August 2017 at 07:46, Arvind Yadav <arvind.yadav.cs@...il.com> wrote:
> clk_prepare_enable() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@...il.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>  drivers/mmc/host/wmt-sdmmc.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/wmt-sdmmc.c b/drivers/mmc/host/wmt-sdmmc.c
> index 21ebba8..e64f930 100644
> --- a/drivers/mmc/host/wmt-sdmmc.c
> +++ b/drivers/mmc/host/wmt-sdmmc.c
> @@ -856,7 +856,9 @@ static int wmt_mci_probe(struct platform_device *pdev)
>                 goto fail5;
>         }
>
> -       clk_prepare_enable(priv->clk_sdmmc);
> +       ret = clk_prepare_enable(priv->clk_sdmmc);
> +       if (ret)
> +               goto fail6;
>
>         /* configure the controller to a known 'ready' state */
>         wmt_reset_hardware(mmc);
> @@ -866,6 +868,8 @@ static int wmt_mci_probe(struct platform_device *pdev)
>         dev_info(&pdev->dev, "WMT SDHC Controller initialized\n");
>
>         return 0;
> +fail6:
> +       clk_put(priv->clk_sdmmc);
>  fail5:
>         free_irq(dma_irq, priv);
>  fail4:
> --
> 1.9.1
>