linux-kernel - Question about bh1770glc.ko

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Aug 2017 15:46:18 +0300
From:   Anton Volkov <avolkov@...ras.ru>
To:     arnd@...db.de, gregkh@...uxfoundation.org
Cc:     linux-kernel@...r.kernel.org, ldv-project@...uxtesting.org,
        Alexey Khoroshilov <khoroshilov@...ras.ru>,
        samu.p.onkalo@...ia.com
Subject: Question about bh1770glc.ko

Hello.

In drivers/misc/bh1770glc.c several functions have comments stating that 
they must be called under lock protection, e.g. 
bh1770_prox_mode_control, bh1770_lux_interrupt_control, bh1770_lux_rate, 
bh1770_chip_on. However there are places where they are called without 
lock being held, e.g. during the bh1770_resume. Do you know anything 
about whether this is intended or this is a bug?

Thank you for your time.

-- Anton Volkov
Linux Verification Center, ISPRAS
web: http://linuxtesting.org
e-mail: avolkov@...ras.ru