lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 13 Aug 2017 03:15:10 -0700 From: Christoph Hellwig <hch@...radead.org> To: Long Li <longli@...hange.microsoft.com> Cc: Steve French <sfrench@...ba.org>, linux-cifs@...r.kernel.org, samba-technical@...ts.samba.org, linux-kernel@...r.kernel.org, Long Li <longli@...rosoft.com> Subject: Re: [[PATCH v1] 08/37] [CIFS] SMBD: Define packet format for SMBD data transfer message > +// SMBD data transfer packet with payload [MS-SMBD] 2.2.3 > +struct smbd_data_transfer { > + __le16 credits_requested; > + __le16 credits_granted; > + __le16 flags; > + __le16 reserved; > + __le32 remaining_data_length; > + __le32 data_offset; > + __le32 data_length; > + __le32 padding; > + char buffer[0]; Please use the actually standardized [] syntax for variable sized arrays. Also normally this would be a __u8 to fit with the other types, but I haven't seen the usage yet. > +} __packed; The structure is natually packed already, no need to add the attribute.
Powered by blists - more mailing lists