linux-kernel - Re: [PATCH] signal: don't remove SIGNAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20170815161658.GA1344@redhat.com>
Date:   Tue, 15 Aug 2017 18:16:58 +0200
From:   Oleg Nesterov <oleg@...hat.com>
To:     Jamie Iles <jamie.iles@...cle.com>
Cc:     linux-kernel@...r.kernel.org,
        Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] signal: don't remove SIGNAL_UNKILLABLE for traced tasks.

On 08/15, Jamie Iles wrote:
>
> --- a/kernel/signal.c
> +++ b/kernel/signal.c
> @@ -1194,7 +1194,11 @@ force_sig_info(int sig, struct siginfo *info, struct task_struct *t)
>  			recalc_sigpending_and_wake(t);
>  		}
>  	}
> -	if (action->sa.sa_handler == SIG_DFL)
> +	/*
> +	 * Don't clear SIGNAL_UNKILLABLE for traced tasks, users won't expect
> +	 * debugging to leave init killable.
> +	 */
> +	if (action->sa.sa_handler == SIG_DFL && !t->ptrace)
>  		t->signal->flags &= ~SIGNAL_UNKILLABLE;
>  	ret = specific_send_sig_info(sig, info, t);
>  	spin_unlock_irqrestore(&t->sighand->siglock, flags);

Acked-by: Oleg Nesterov <oleg@...hat.com>