lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20170815.103651.1877616739706523154.davem@davemloft.net>
Date:   Tue, 15 Aug 2017 10:36:51 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     rdunlap@...radead.org
Cc:     ncardwell@...gle.com, mohamed.a.alrshah@...e.org,
        netdev@...r.kernel.org, torvalds@...ux-foundation.org,
        linux-kernel@...r.kernel.org, mothman@....edu.my,
        borhan@....edu.my, zurinamh@....edu.my
Subject: Re: [PATCH]
 Adding-Agile-SD-TCP-module-and-modifying-Kconfig-and-makefile

From: Randy Dunlap <rdunlap@...radead.org>
Date: Tue, 15 Aug 2017 09:41:53 -0700

> On 08/15/2017 06:51 AM, Neal Cardwell wrote:
>> On Tue, Aug 15, 2017 at 9:08 AM, mohamedalrshah
>> <mohamed.a.alrshah@...e.org> wrote:
>> 
>>> +static void agilesdtcp_cong_avoid(struct sock *sk, u32 ack, u32 in_flight)
>>> +{
>>> +       struct tcp_sock *tp = tcp_sk(sk);
>>> +       struct agilesdtcp *ca = inet_csk_ca(sk);
>>> +       u32 inc_factor;
>>> +       u32 ca_inc;
>>> +       u32 current_gap, total_gap;
>> 
>> For coding style, please order local variable declarations from
>> longest to shortest line, also know as Reverse Christmas Tree Format.
> 
> Per what coding style, please?  This is not in current coding style nor in the
> netdev-FAQ exceptions.

It is the established practice, documented or not, and I enforce this for all
networking code submissions.

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ