linux-kernel - Re: [PATCH v2] lockdep: Make LOCKDEP_CROSSRELEASE configs all part of PROVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2017 10:17:10 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Byungchul Park <byungchul.park@....com>
Cc:     peterz@...radead.org, linux-kernel@...r.kernel.org,
        kernel-team@....com
Subject: Re: [PATCH v2] lockdep: Make LOCKDEP_CROSSRELEASE configs all part
 of PROVE_LOCKING


* Byungchul Park <byungchul.park@....com> wrote:

> Crossrelease added LOCKDEP_CROSSRELEASE and LOCKDEP_COMPLETE configs. It
> makes little sense to enable them when PROVE_LOCKING is disabled.
> 
> Make them non-interative option and all part of PROVE_LOCKING.
> 
> Signed-off-by: Byungchul Park <byungchul.park@....com>
> ---
>  lib/Kconfig.debug | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index ee9e534..84bb4c5 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1084,6 +1084,8 @@ config PROVE_LOCKING
>  	select DEBUG_MUTEXES
>  	select DEBUG_RT_MUTEXES if RT_MUTEXES
>  	select DEBUG_LOCK_ALLOC
> +	select LOCKDEP_CROSSRELEASE
> +	select LOCKDEP_COMPLETE
>  	select TRACE_IRQFLAGS
>  	default n
>  	help
> @@ -1155,8 +1157,6 @@ config LOCK_STAT
>  
>  config LOCKDEP_CROSSRELEASE
>  	bool "Lock debugging: make lockdep work for crosslocks"
> -	depends on PROVE_LOCKING
> -	default n
>  	help
>  	 This makes lockdep work for crosslock which is a lock allowed to
>  	 be released in a different context from the acquisition context.
> @@ -1167,9 +1167,6 @@ config LOCKDEP_CROSSRELEASE
>  
>  config LOCKDEP_COMPLETE
>  	bool "Lock debugging: allow completions to use deadlock detector"
> -	depends on PROVE_LOCKING
> -	select LOCKDEP_CROSSRELEASE
> -	default n

BTW., and I just noticed this, "LOCKDEP_COMPLETE" is a misnomer: it should be 
"LOCKDEP_COMPLETIONS".

Think about it, 'complete' is an adjective, and the current name suggests 'lockdep 
is complete' or so, so it's pretty confusing.

So let's do a (separate) renaming patch as well.

Also, while at it:

>  	bool "Lock debugging: make lockdep work for crosslocks"

Please word that more directly - lockdep doesn't have to be made to work with 
crosslocks - it works with them, what the option does is that it enables crosslock 
support. I.e.:

	bool "Lock debugging: enable cross-locking checks in lockdep"

or so.

Thanks,

	Ingo