linux-kernel - Re: [RFC PATCH 6/7] mmc: sdhci-omap: Add OMAP SDHCI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2017 11:23:34 +0300
From:   Adrian Hunter <adrian.hunter@...el.com>
To:     Kishon Vijay Abraham I <kishon@...com>,
        Ulf Hansson <ulf.hansson@...aro.org>,
        Tony Lindgren <tony@...mide.com>,
        Rob Herring <robh+dt@...nel.org>
Cc:     nsekhar@...com, linux-omap@...r.kernel.org,
        linux-mmc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 6/7] mmc: sdhci-omap: Add OMAP SDHCI driver

On 17/08/17 10:59, Kishon Vijay Abraham I wrote:
> Hi Adrian,
> 
> On Thursday 17 August 2017 12:13 PM, Adrian Hunter wrote:
>> On 17/08/17 08:57, Kishon Vijay Abraham I wrote:
>>> Hi Adrian,
>>>
>>> On Tuesday 15 August 2017 01:52 PM, Adrian Hunter wrote:
>>>> On 07/08/17 19:01, Kishon Vijay Abraham I wrote:

<SNIP>

>>>>> +	pm_runtime_enable(dev);
>>>>> +	ret = pm_runtime_get_sync(dev);
>>>>
>>>> What are you trying to do with runtime pm?  There don't seem to be any pm
>>>> callbacks, so does this do anything?
>>>
>>> yeah, pm_runtime_get_sync enables the functional clock and also configures the
>>> SYSCONFIG regiters present in the controller. It gets the details for
>>> configuring those from arch/arm/mach-omap2/omap_hwmod_*
>>
>> You mean it will do those things when you add the callbacks?  I would prefer
>> you leave out runtime pm until you can add the callbacks as well.
> 
> No. Generally in callbacks, 'optional' functional clocks are enabled. But main
> functional clock and interface clocks are enabled in pm_runtime_get_sync.
> Without pm_runtime_get_sync, we won't be able to access controller registers.

So that is done by the pm domain?  Please add comments to the code to explain.