linux-kernel - Re: [RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 17 Aug 2017 16:51:44 +0300
From:   Laurent Pinchart <laurent.pinchart@...asonboard.com>
To:     Javier Martinez Canillas <javier@...hile0.org>
Cc:     Philipp Zabel <p.zabel@...gutronix.de>,
        Linux Kernel <linux-kernel@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Linux Media Mailing List <linux-media@...r.kernel.org>
Subject: Re: [RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support"

Hello,

On Thursday 17 Aug 2017 15:49:51 Javier Martinez Canillas wrote:
> On Thu, Aug 17, 2017 at 3:05 PM, Philipp Zabel wrote:
> > On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote:
> >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
> >> added input signals support for the tvp5150, but the approach was found
> >> to be incorrect so the corresponding DT binding commit 82c2ffeb217a
> >> ("[media] tvp5150: document input connectors DT bindings") was reverted.
> >> 
> >> This left the driver with an undocumented (and wrong) DT parsing logic,
> >> so lets get rid of this code as well until the input connectors support
> >> is implemented properly.
> >> 
> >> It's a partial revert due other patches added on top of mentioned commit
> >> not allowing the commit to be reverted cleanly anymore. But all the code
> >> related to the DT parsing logic and input entities creation are removed.
> >> 
> >> > Suggested-by: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> >> > Signed-off-by: Javier Martinez Canillas <javier@....samsung.com>
> > 
> > what is the state of this patch? Was it forgotten or was the revert
> > deemed unnecessary?
> 
> I think that was just forgotten. That code still needs to be reverted
> since the DT patch was also reverted.

Yes, I think it was just forgotten.

> Albeit the code is harmless since should be a no-op if a connectors DT
> node isn't found.

-- 
Regards,

Laurent Pinchart